Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic typing to pylint/message #5101

Merged
merged 1 commit into from
Oct 2, 2021

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
βœ“ πŸ”¨ Refactoring

Description

Ref #2079 (comment)
This allows ticking of pylint/message/message_definition.py, pylint/message/message_definition_store.py and pylint/message/message_id_store.py from the list.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1298365659

  • 12 of 13 (92.31%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 93.11%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pylint/message/message_id_store.py 7 8 87.5%
Totals Coverage Status
Change from base Build 1294541154: -0.005%
Covered Lines: 13393
Relevant Lines: 14384

πŸ’› - Coveralls

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

@DanielNoord DanielNoord merged commit 86c073e into pylint-dev:main Oct 2, 2021
@DanielNoord DanielNoord deleted the typing-message branch October 2, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants