Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic typing to pylint/pyreverse #5102

Merged
merged 1 commit into from
Oct 2, 2021

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Write a good description on what the PR does.

Type of Changes

Type
βœ“ πŸ”¨ Refactoring

Description

Ref #2079 (comment)
This allows ticking of pylint/pyreverse/dot_printer.py, pylint/pyreverse/printer.py and pylint/pyreverse/printer_factory.py from the list.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1298382108

  • 5 of 5 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.115%

Totals Coverage Status
Change from base Build 1294541154: 0.0%
Covered Lines: 13390
Relevant Lines: 14380

πŸ’› - Coveralls

@DudeNr33
Copy link
Collaborator

DudeNr33 commented Oct 2, 2021

Thanks for catching those places I missed! 😊

@DudeNr33 DudeNr33 merged commit 87ab1bd into pylint-dev:main Oct 2, 2021
@DanielNoord DanielNoord deleted the typing-pyreverse branch October 2, 2021 14:34
@DanielNoord
Copy link
Collaborator Author

The pyreverse directory is actually pretty well typed for pylint's standard. I think we have you to thank for that πŸ‘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants