Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unnecessary-ellipsis false positive: allow ellipsis as default argument #6007

Merged
merged 4 commits into from
Mar 28, 2022
Merged

unnecessary-ellipsis false positive: allow ellipsis as default argument #6007

merged 4 commits into from
Mar 28, 2022

Conversation

jpy-git
Copy link
Contributor

@jpy-git jpy-git commented Mar 27, 2022

Type of Changes

Type
✓ 🐛 Bug fix

Description

Closes #5973

Fix false positive for unnecessary-ellipsis when using an ellipsis as a default argument.

@coveralls
Copy link

coveralls commented Mar 27, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2051247931

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.154%
Totals Coverage Status
Change from base Build 2051102975: 0.0%
Covered Lines: 15334
Relevant Lines: 16286
💛 - Coveralls

DanielNoord
DanielNoord reviewed Mar 28, 2022
View reviewed changes
ChangeLog Outdated Show resolved Hide resolved
@Pierre-Sassoulas Pierre-Sassoulas added the False Positive 🦟 A message is emitted but nothing is wrong with the code label Mar 28, 2022
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.13.3 milestone Mar 28, 2022
@Pierre-Sassoulas Pierre-Sassoulas added the Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer label Mar 28, 2022
DanielNoord
DanielNoord approved these changes Mar 28, 2022
View reviewed changes
Copy link
Collaborator

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jpy-git!

@DanielNoord DanielNoord merged commit 209030d into pylint-dev:main Mar 28, 2022
@toofar toofar mentioned this pull request Mar 29, 2022
Merged
Pierre-Sassoulas pushed a commit that referenced this pull request Mar 29, 2022
@jpy-git @Pierre-Sassoulas
unnecessary-ellipsis false positive: allow ellipsis as default argu…
c733530 
…ment (#6007)
@Pierre-Sassoulas Pierre-Sassoulas added Backported and removed Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer labels Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

@DanielNoord DanielNoord DanielNoord approved these changes

Assignees
No one assigned
Labels
Backported False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Milestone
2.13.3
Development

Successfully merging this pull request may close these issues.

(🐞) false error unnecessary-ellipsis when ellipsis (...) is used as a value
4 participants
@jpy-git @coveralls @Pierre-Sassoulas @DanielNoord