Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin colorama to lowest supported version #6970

Merged
merged 1 commit into from
Jun 18, 2022
Merged

Pin colorama to lowest supported version #6970

merged 1 commit into from
Jun 18, 2022

Conversation

DanielNoord
Copy link
Collaborator

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature, or an important bug fix, add a What's New entry in
    doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.

Type of Changes

Type
✓ 🐛 Bug fix

Description

After tartley/colorama#341 has been merged we can now "fix" #6012.

We should pin colorama to this version now.

@DanielNoord DanielNoord added Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer dependency Label for github dependabot labels Jun 18, 2022
@DanielNoord DanielNoord added this to the 2.14.3 milestone Jun 18, 2022
@DanielNoord DanielNoord mentioned this pull request Jun 18, 2022
Closed
Pierre-Sassoulas
Pierre-Sassoulas approved these changes Jun 18, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks I forgot that despite following the discussion closely !

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2519628050

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.262%
Totals Coverage Status
Change from base Build 2519626889: 0.0%
Covered Lines: 16546
Relevant Lines: 17369
💛 - Coveralls

@Pierre-Sassoulas Pierre-Sassoulas merged commit cac381d into pylint-dev:main Jun 18, 2022
Pierre-Sassoulas pushed a commit to Pierre-Sassoulas/pylint that referenced this pull request Jun 18, 2022
@DanielNoord @Pierre-Sassoulas
Pin colorama to lowest supported version (pylint-dev#6970)
f56819e
@DanielNoord DanielNoord deleted the colorama branch June 18, 2022 07:35
@Pierre-Sassoulas Pierre-Sassoulas added Backported and removed Needs backport Needs to be cherry-picked on the current patch version by a pylint's maintainer labels Jun 18, 2022
Pierre-Sassoulas pushed a commit to Pierre-Sassoulas/pylint that referenced this pull request Jun 18, 2022
@DanielNoord @Pierre-Sassoulas
Pin colorama to lowest supported version (pylint-dev#6970)
23a1245
Pierre-Sassoulas pushed a commit that referenced this pull request Jun 18, 2022
@DanielNoord @Pierre-Sassoulas
Pin colorama to lowest supported version (#6970)
b05ac51
@cmorsbach cmorsbach mentioned this pull request Oct 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Backported dependency Label for github dependabot
Projects
None yet
Milestone
2.14.3
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielNoord @coveralls @Pierre-Sassoulas