-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn on mypy
strict mode 🎉
#7448
Conversation
5283f0f
to
0469eec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to fix those in a follow-up issue or do you think they are all justified ? Should we add a comment to tell why they're ignored ?
They are ignored because |
Pull Request Test Coverage Report for Build 3025221938
💛 - Coveralls |
🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉 This comment was generated for commit 0469eec |
towncrier create <IssueNumber>.<type>
which will beincluded in the changelog.
<type>
can be one of: new_check, removed_check, extension,false_positive, false_negative, bugfix, other, internal. If necessary you can write
details or offer examples on how the new change is supposed to work.
and preferred name in
script/.contributors_aliases.json
Type of Changes
Description
🎉