Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on mypy strict mode 🎉 #7448

Merged
merged 5 commits into from
Sep 9, 2022

Conversation

DanielNoord
Copy link
Collaborator

  • Write a good description on what the PR does.
  • Create a news fragment with towncrier create <IssueNumber>.<type> which will be
    included in the changelog. <type> can be one of: new_check, removed_check, extension,
    false_positive, false_negative, bugfix, other, internal. If necessary you can write
    details or offer examples on how the new change is supposed to work.
  • If you used multiple emails or multiple names when contributing, add your mails
    and preferred name in script/.contributors_aliases.json

Type of Changes

Type
🔨 Refactoring

Description

🎉

@DanielNoord DanielNoord added Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry labels Sep 9, 2022
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to fix those in a follow-up issue or do you think they are all justified ? Should we add a comment to tell why they're ignored ?

@DanielNoord
Copy link
Collaborator Author

Do we need to fix those in a follow-up issue or do you think they are all justified ? Should we add a comment to tell why they're ignored ?

They are ignored because mypy sets all imported modules it can't understand to Any. They will all become redundant whenever astroid or any of the other modules adds the py.typed file.
Adding the comment everywhere would be a bit too much I think.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3025221938

  • 55 of 56 (98.21%) changed or added relevant lines in 21 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.0005%) to 95.315%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pylint/utils/utils.py 1 2 50.0%
Totals Coverage Status
Change from base Build 3025218682: -0.0005%
Covered Lines: 17027
Relevant Lines: 17864

💛 - Coveralls

@DanielNoord DanielNoord merged commit 0cc82c4 into pylint-dev:main Sep 9, 2022
@DanielNoord DanielNoord deleted the typing-checkers-4 branch September 9, 2022 21:05
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 0469eec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants