Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge maintenance/2.15.x in main following 2.15.6 release #7799

Merged

Conversation

Pierre-Sassoulas
Copy link
Member

No description provided.

cdce8p and others added 17 commits November 17, 2022 14:03
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
* short-circuit if next method doesnt have args
* check for builtins.next qname
* add inference confidence level
* Remove restore keys
* Log pylint + astroid versions
* Reset cache versions
* Add check-latest to setup-python
* Use pyproject.toml for hash
* Update comment-hider version comment
* Pin additional actions
* Use release version for astroid
* Use better cache key
* Mirror create environment
* Update comments
* Fix a crash when a child class with an ``__init__`` method inherits from a parent class with an ``__init__`` class attribute.

* `continue` if not a method.

* Update pylint/checkers/classes/class_checker.py

* Rename fragment

Closes pylint-dev#7742

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
…dev#7685)

* do not report unnecessary list index lookup if start arg is passed

* account for calling start with 0 or negative num

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
…`. (pylint-dev#7757)

Closes pylint-dev#7501

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
* Bump pylint to 2.15.6, update changelog

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
@Pierre-Sassoulas Pierre-Sassoulas added Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry labels Nov 19, 2022
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.15.6 milestone Nov 19, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3502789132

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.413%

Totals Coverage Status
Change from base Build 3499918878: 0.0%
Covered Lines: 17391
Relevant Lines: 18227

💛 - Coveralls

Comment on lines +1 to 3
Messages sent to reporter are now copied so a reporter cannot modify the message sent to other reporters.

Closes #7214
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fragment should probably be removed as it's included in the changelog for 2.15.6.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's voluntary to include the released notes from patches in minor's whatsnew. It's also convenient as when you merge back the removal need to be done manually again.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find the discussion about it :( Here we go : #7426 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only reason we have a diff on this fragment versus the others is because I suggested a grammar fix on this fragment that Pierre committed at release time.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only reason we have a diff on this fragment versus the others is because I suggested a grammar fix on this fragment that Pierre committed at release time.

👍🏻

I think it's voluntary to include the released notes from patches in minor's whatsnew. It's also convenient as when you merge back the removal need to be done manually again.

I was thinking about it the wrong way. We still "need" them for main as they technically aren't released yet, just backported.

@Pierre-Sassoulas Pierre-Sassoulas merged commit 7249be0 into pylint-dev:main Nov 19, 2022
@Pierre-Sassoulas Pierre-Sassoulas deleted the merge-2.15.6-in-main branch November 19, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants