Fix false negative for calling module-level function before definition

[jacobtylerwalls]

Type of Changes

	Type
✓	🐛 Bug fix

Description

Closes #1144

[codecov]

Codecov Report

Merging #8494 (6be389a) into main (a59f3d5) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8494      +/-   ##
==========================================
- Coverage   95.81%   95.81%   -0.01%     
==========================================
  Files         174      174              
  Lines       18321    18319       -2     
==========================================
- Hits        17554    17552       -2     
  Misses        767      767              

Impacted Files	Coverage Δ
pylint/checkers/variables.py	97.24% <100.00%> (-0.01%)	⬇️

[github-actions]

🤖 Effect of this PR on checked open source code: 🤖

Effect on astroid:
The following messages are now emitted:

1. used-before-assignment:
   Using variable '_class_type' before assignment
   https://github.com/pylint-dev/astroid/blob/495581f0ff1b0513397b9177c62f27e702e11bb2/astroid/nodes/scoped_nodes/scoped_nodes.py#L1947

Effect on django:
The following messages are now emitted:

1. used-before-assignment:
   Using variable 'validators' before assignment
   https://github.com/django/django/blob/255f5345904854128647705adcb8d21138e87c63/django/db/models/fields/__init__.py#L120

Effect on poetry-core:
The following messages are now emitted:

1. used-before-assignment:
   Using variable 'operator' before assignment
   https://github.com/python-poetry/poetry-core/blob/81805766cf57563b626b3bde41f4edfd7e4b08e9/src/poetry/core/constraints/generic/constraint.py#L12

This comment was generated for commit 3fdf7fe

[Pierre-Sassoulas]

LGTM !

[jacobtylerwalls]

I was going to wait for a new primer result, but if there are follow-ups, I'll just open a new PR. Sorry for not saying something sooner!

[Pierre-Sassoulas]

That's my bad for merging too fast :)

[jacobtylerwalls]

No worries, I just checked and I can't reproduce the 2nd and 3rd items from the earlier primer comment, so I think they were also property-related like the 1st one I addressed in astroid (and checking the files confirms it) 🎉