Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade astroid to 2.15.3 #8584

Merged
merged 2 commits into from
Apr 23, 2023

Conversation

Pierre-Sassoulas
Copy link
Member

Type of Changes

Type
✨ New feature

Description

Upgrade astroid for next patch release.

@Pierre-Sassoulas Pierre-Sassoulas added Maintenance Discussion or action around maintaining pylint or the dev workflow backport maintenance/3.3.x labels Apr 16, 2023
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.17.3 milestone Apr 16, 2023
@Pierre-Sassoulas Pierre-Sassoulas added the Skip news 🔇 This change does not require a changelog entry label Apr 16, 2023
@jacobtylerwalls
Copy link
Member

Are you able to reproduce the failure?

@Pierre-Sassoulas
Copy link
Member Author

I need to install an older python interpreter, I'm going to check that tomorrow.

@github-actions
Copy link
Contributor

🤖 Effect of this PR on checked open source code: 🤖

Effect on pytest:
The following messages are no longer emitted:

  1. no-name-in-module:
    No name 'cleanup_dead_symlinks' in module '_pytest.pathlib'
    https://github.com/pytest-dev/pytest/blob/4eca6063c8df11a0bb8dbe23745294aa5d5fec67/src/_pytest/tmpdir.py#L31
  2. no-name-in-module:
    No name 'get_user_id' in module '_pytest.compat'
    https://github.com/pytest-dev/pytest/blob/4eca6063c8df11a0bb8dbe23745294aa5d5fec67/src/_pytest/tmpdir.py#L32

This comment was generated for commit 043e6a4

@Pierre-Sassoulas
Copy link
Member Author

I won't be able to reproduce this or release pylint 2.17.3 before at least this week-end (traveling for work). astroid 2.15.3 is live so we might have a regression on our hand in pylint 2.17.2 (#4439)

@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Merging #8584 (154f1ae) into main (4d46d94) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8584   +/-   ##
=======================================
  Coverage   95.92%   95.92%           
=======================================
  Files         174      174           
  Lines       18415    18415           
=======================================
  Hits        17664    17664           
  Misses        751      751           

@Pierre-Sassoulas
Copy link
Member Author

Nice catch @cdce8p, I missed that attr is not in pytest anymore and I reviewed that changelog entry in pytest 🤦

@cdce8p cdce8p merged commit 3d036b7 into pylint-dev:main Apr 23, 2023
github-actions bot pushed a commit that referenced this pull request Apr 23, 2023
Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
(cherry picked from commit 3d036b7)
Pierre-Sassoulas added a commit that referenced this pull request Apr 23, 2023
Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
(cherry picked from commit 3d036b7)
@Pierre-Sassoulas Pierre-Sassoulas deleted the upgrade-astroid-to-2.15.3 branch April 24, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants