improve readability

[fabinca]

From the docs:

A tuple, as in isinstance(x, (A, B, ...)), may be given as the target to check against. This is equivalent to isinstance(x, A) or isinstance(x, B) or ... etc.

Type of Changes

	Type

| ✓ | 🔨 Refactoring |

Description

Refs #XXXX

Closes #XXXX

[Pierre-Sassoulas]

Thank you, it seems reasonable, but some tests are not passing anymore which is strange. Maybe there's some side effects here. Do oyu want to investigate ?

[jacobtylerwalls]

FunctionDef is a LocalsDictNodeNG, so from the failing tests I take it this needs to run twice to maintain the same behavior. I think the current way is fine (but might have benefitted from a comment in the code).

[fabinca]

Ok, I see, thanks. Do you think it would make sense to look into refactoring the method

self._populate_type_annotations_function(
                       usage_node, all_used_type_annotations
                   )

to make it idempotent, or is this behaviour wanted?

[jacobtylerwalls]

Thanks for the reply. I agree that the current design is not totally straightforward, but I just would prefer to see us direct energies toward other higher-impact areas than refactoring working code. I hope that makes sense 👍