Fix false-positive with contextmanager missing cleanup

[cdce8p]

Type of Changes

	Type
✓	🐛 Bug fix

Description

An attempt at fixing the false-positives with the contextmanager-generator-missing-cleanup check where no cleanup happens after a singular yield.

Closes #9625

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.84%. Comparing base (fbc1ed3) to head (509eb93).
Report is 163 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9654   +/-   ##
=======================================
  Coverage   95.84%   95.84%           
=======================================
  Files         174      174           
  Lines       18896    18915   +19     
=======================================
+ Hits        18110    18129   +19     
  Misses        786      786           

Files	Coverage Δ
pylint/checkers/base/function_checker.py	93.10% <100.00%> (-6.90%)	⬇️

... and 9 files with indirect coverage changes

[Pierre-Sassoulas]

We might want to document the known false positives from #9625 (comment) in détails.rst ?

[cdce8p]

We might want to document the known false positives from #9625 (comment) in details.rst ?

Done. I've also updated the error node to use the with_node instead of the FuncDef. While technically this might be a small breaking change, I think this improves the error message especially for long generator functions with multiple if blocks.

[Pierre-Sassoulas]

LGTM

[github-actions]

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 509eb93