Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resized welcome-bot banners #29

Merged
merged 1 commit into from
Jun 30, 2024
Merged

Add resized welcome-bot banners #29

merged 1 commit into from
Jun 30, 2024

Conversation

markgreene74
Copy link
Contributor

Re pymc-devs/pymc#7323

With this PR we are adding a new version of the welcome-bot banners (resized to 910x483).

The images were resized with ImageMagick.

Example:

convert -resize 910x BannerCongratulations.jpg -quality 90 BannerCongratulations_resized_910.png

@reshamas
Copy link
Collaborator

@markgreene74
Thanks for this PR. Is there a specific reason why the images need to be resized?

@markgreene74
Copy link
Contributor Author

Is there a specific reason why the images need to be resized?

Hi @reshamas - it's related to pymc-devs/pymc#7323

@reshamas
Copy link
Collaborator

@markgreene74 OK, thanks for the background.
Can you add the original images back and rename then with a prefix "_orig". That way in case we need them to resize, or some other reason, they are available here.

After that, we can merge this PR in.

@markgreene74
Copy link
Contributor Author

That's done now @reshamas

@twiecki twiecki requested a review from reshamas June 30, 2024 11:06
@reshamas
Copy link
Collaborator

Thank you @markgreene74

@reshamas reshamas merged commit 9256935 into pymc-devs:main Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants