Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin pymc==5.14 #162

Merged
merged 4 commits into from
May 8, 2024
Merged

Conversation

juanitorduz
Copy link
Contributor

@juanitorduz juanitorduz commented May 1, 2024

As we have new releases (https://github.com/pymc-devs/pymc/releases) regularly, I suggest we unpin the exact versions of PyMC and Arviz :)

I changed the scope and just pinned the latest version.

I also removed the pre-commit restrictions as they are not necessary

@juanitorduz juanitorduz self-assigned this May 1, 2024
@juanitorduz juanitorduz added the maintenance Code style and repo configuration label May 1, 2024
@juanitorduz
Copy link
Contributor Author

@aloctavodia 👋

@aloctavodia
Copy link
Member

We pinned the versions precisely because of the frecuent releases. A common scenario is that pymc-bart import fails due to a sudden change in a module name or function.

It is possible to automatically run tests for every new pymc/arviz release?

@juanitorduz
Copy link
Contributor Author

Ahh ok! I don't think I know about doing this automatically.

I'll close this one and open another one for the upgrade to 5.14 😄

@juanitorduz juanitorduz closed this May 8, 2024
@juanitorduz juanitorduz deleted the relax-pymc-versions branch May 8, 2024 12:48
@juanitorduz juanitorduz restored the relax-pymc-versions branch May 8, 2024 18:12
@juanitorduz juanitorduz reopened this May 8, 2024
@juanitorduz juanitorduz changed the title Relax pymc and arviz versions pin pymc==5.14 May 8, 2024
@juanitorduz
Copy link
Contributor Author

We pinned the versions precisely because of the frecuent releases. A common scenario is that pymc-bart import fails due to a sudden change in a module name or function.

It is possible to automatically run tests for every new pymc/arviz release?

Shall we still upgrade to the latest version? 5d7fff1

@aloctavodia
Copy link
Member

Updating makes sense.

@aloctavodia aloctavodia merged commit ee6a348 into pymc-devs:main May 8, 2024
4 checks passed
@juanitorduz juanitorduz deleted the relax-pymc-versions branch May 8, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Code style and repo configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants