Bump version to 3.0.rc3 #1458
Bump version to 3.0.rc3 #1458
Conversation
|
Wow :) We're nearly there :) |
|
Noticed that at least one of the notebooks in master is broken. I'm going to go in and hand run all of them to ensure they are all working. |
|
Cool - that's a good catch :) |
|
I'm not comfortable releasing 3.0 until all of the examples and notebooks run without error. This is currently not the case. Working on this in #1465 |
|
Agreed. On Oct 28, 2016 10:42 PM, "Chris Fonnesbeck" notifications@github.com
|
|
Seems you need the latest Theano to get through some of the notebooks. Been checking it locally. |
|
Actually moved this to a cleaner PR #1535 |
|
@springcoil yes, its a little uncomfortable having a release more or less dependent on the latest master of Theano, but what can you do? |
|
It's fine :) |
|
Instead bumping to 3.0.rc3. |
|
Is this ready to be launched yet? |
|
I think a RC is probably a good idea. I will try to get to it today/tonight. |
|
Yeah agreed
…On Tue, Nov 29, 2016 at 7:23 PM, Chris Fonnesbeck ***@***.***> wrote:
I think a RC is probably a good idea. I will try to get to it
today/tonight.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1458 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA8DiHPJpN5Ab8uiDax4Sq70pmHX_BWuks5rDHuqgaJpZM4KZtid>
.
--
Peadar Coyle
Skype: springcoilarch
www.twitter.com/springcoil
peadarcoyle.wordpress.com
|
|
I went ahead and drafted a release candidate, with the current master. I guess @fonnesbeck and/or @twiecki should give the final say. |
|
I was waiting until the |
|
Ohh I'm sorry. I didn't realize that was the blocker :) |
|
It's not a blocker for an RC, its just an arbitrary cutoff :-). As long as it gets into the final release, i will be happy. |
|
Yeah it should definitely be in the final release. Do I go ahead and stick a version on conda-forge? |
|
Yes. I can do PyPI. |
|
conda-forge/pymc3-feedstock#2 is the Conda-Forge update |
|
@springcoil unless I'm mistaken, you did not increment the version in the RC. Still says rc2 in the source on master. |
|
I'll fix it. That's possible
…On 1 Dec 2016 10:07 PM, "Chris Fonnesbeck" ***@***.***> wrote:
@springcoil <https://github.com/springcoil> unless I'm mistaken, you did
not increment the version in the RC. Still says rc2 in the source on master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1458 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA8DiAa9EcpN_aPjDv7BfLzL-mI5pK46ks5rD0U2gaJpZM4KZtid>
.
|
|
Yeah, I'm confused about the tag. We have a 3.0rc3 tag, but it does not appear to correspond to the master branch. |
|
Fixed it - I think |
|
No, master still has rc2 as the version. Let's burn this release candidate and go to rc4. I will put it together right now. |
|
Ok |
|
Ah, I see the issue now. This was my fault, sorry. Closing this. |
|
We now have RC4 tagged and uploaded to PyPI. |
|
Just commenting on this conda-forge/pymc3-feedstock#2 - RC4 now builds on Conda-Forge and should be merged soon. cc @twiecki @fonnesbeck |
|
Haven't heard a peep about RC issues. |
|
|
|
We can probably go ahead with the 3.0 release in a few days! |
This is it!