-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gaussian process functions and classes #1794
Conversation
Getting close, but the GP class returns biased estimates. |
Have a peek at the interface. I have updated the GP-introduction notebook in this PR to use it. Predictive sampling now happens outside of MCMC sampling, using /cc @bwengals |
API looks great! Would the new ESS work well here? |
This is awesome! Yeah, this looks good to me. Also, looks like NUTS and ADVI did well! I had trouble getting those to work. That is very cool. |
@bwengals NUTS and ADVI did not work well on the second example -- ADVI kept getting nans. |
Oh, huh. I wonder why. Well I like the new GP class. |
Using two-stage integration seemed to help quite a lot with the second example. |
Need to write some tests and docs, and we should be good. |
can you pass integrator='two-stage' to sample() to still get ADVI init? We might need to improve the kwarg forwarding. |
ADVI init kept failing with NaN errors, so I turned it off. |
Unusual test failure only on 2.7. Is it a different version of Theano there? |
This appears to pass now. I will add docs in a separate PR. |
This is great |
Yes, this is really exciting! I have an old talk on Bayesian optimization that I'm excited to port to |
I'd be interested in seeing that! |
Replaces
gp_classes
branch. Will eventually include aGP
class, mean functions, and a function for drawing realizations from the GP after sampling.