Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gaussian process functions and classes #1794

Merged
merged 14 commits into from
Feb 21, 2017
Merged

Gaussian process functions and classes #1794

merged 14 commits into from
Feb 21, 2017

Conversation

fonnesbeck
Copy link
Member

Replaces gp_classes branch. Will eventually include a GP class, mean functions, and a function for drawing realizations from the GP after sampling.

@fonnesbeck
Copy link
Member Author

Getting close, but the GP class returns biased estimates.

@fonnesbeck
Copy link
Member Author

Have a peek at the interface. I have updated the GP-introduction notebook in this PR to use it. Predictive sampling now happens outside of MCMC sampling, using sample_gp, which uses the same API as sample_ppc. This seems to make sense to me, but would like to hear what others think.

/cc @bwengals

@twiecki
Copy link
Member

twiecki commented Feb 18, 2017

API looks great! Would the new ESS work well here?

@bwengals
Copy link
Contributor

This is awesome! Yeah, this looks good to me. Also, looks like NUTS and ADVI did well! I had trouble getting those to work. That is very cool.

@fonnesbeck
Copy link
Member Author

@bwengals NUTS and ADVI did not work well on the second example -- ADVI kept getting nans.

@bwengals
Copy link
Contributor

Oh, huh. I wonder why. Well I like the new GP class.

@fonnesbeck
Copy link
Member Author

Using two-stage integration seemed to help quite a lot with the second example.

@fonnesbeck
Copy link
Member Author

Need to write some tests and docs, and we should be good.

@twiecki
Copy link
Member

twiecki commented Feb 20, 2017

can you pass integrator='two-stage' to sample() to still get ADVI init? We might need to improve the kwarg forwarding.

@fonnesbeck
Copy link
Member Author

ADVI init kept failing with NaN errors, so I turned it off.

@fonnesbeck
Copy link
Member Author

Unusual test failure only on 2.7. Is it a different version of Theano there?

@fonnesbeck
Copy link
Member Author

This appears to pass now. I will add docs in a separate PR.

@fonnesbeck fonnesbeck changed the title WIP: Gaussian process functions and classes Gaussian process functions and classes Feb 21, 2017
@fonnesbeck fonnesbeck removed the WIP label Feb 21, 2017
@twiecki twiecki merged commit 04f8c6e into master Feb 21, 2017
@twiecki twiecki deleted the gp_funcs branch February 21, 2017 21:26
@twiecki
Copy link
Member

twiecki commented Feb 21, 2017

This is great

@AustinRochford
Copy link
Member

Yes, this is really exciting! I have an old talk on Bayesian optimization that I'm excited to port to pymc3

@fonnesbeck
Copy link
Member Author

I'd be interested in seeing that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants