-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve static output shape and numba implementations of some Ops #375
Conversation
Looks neat. Question is d5574c1 (fix: Fix shape of subtensors ) fixing a bug or just providing better static shape? |
6e0f246
to
1bd0647
Compare
Usually I just got a None shape, but in the code it seemed to just return shape==1 sometimes: d5574c1#diff-f5839e5efccae3b80e368b3d43abd60c65d64a012eb92a231c682805d4ab1e62L747 Not sure what that was about... |
We needed to know whether the output is broadcastable for the grad. Every thing besides that is just a nice to have that was not implemented I guess. The reason I ask is that it makes it easier for me to review :) |
1a14965
to
d25e2a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Tests looked like they were passing before refreshing :) |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #375 +/- ##
==========================================
- Coverage 80.40% 80.40% -0.01%
==========================================
Files 156 156
Lines 45401 45500 +99
Branches 11106 11141 +35
==========================================
+ Hits 36505 36582 +77
- Misses 6689 6702 +13
- Partials 2207 2216 +9
|
Can this be merged? There's a fix in here for a nutpie bug I keep running into. |
There's a change that has to be reverted, I'll try to get on it Monday, thanks for pinging |
7045b91
to
a53cca3
Compare
Numba doesn't support dot with non-floating point arguments.
a53cca3
to
0e8654c
Compare
A collection of small fixes I have accumulated...
I thought it would be easier to just submit this as one PR instead of 5 small ones. The individual commits contain one fix each.