Don't run merge optimization in ScalarInnerGraphOp.fgraph
#406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
dont-run-merge-scalargraph
branch
2 times, most recently
from
d871ae4
to
5d59338
Compare
ricardoV94
force-pushed
the
dont-run-merge-scalargraph
branch
4 times, most recently
from
9775914
to
a761714
Compare
ricardoV94
changed the title
ScalarInnerGraphOp.fgraph
ricardoV94
changed the title
ScalarInnerGraphOp.fgraphScalarInnerGraphOp.fgraph
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #406 +/- ##
==========================================
+ Coverage 80.47% 80.48% +0.01%
==========================================
Files 156 156
Lines 45584 45566 -18
Branches 11169 11162 -7
==========================================
- Hits 36683 36676 -7
+ Misses 6698 6688 -10
+ Partials 2203 2202 -1
|
ricardoV94
force-pushed
the
dont-run-merge-scalargraph
branch
6 times, most recently
from
366bc18
to
02841dc
Compare
michaelosthege
approved these changes
Aug 21, 2023
This would trigger it for every Composite/ScalarLoop present in the C-cache
ricardoV94
force-pushed
the
dont-run-merge-scalargraph
branch
from
02841dc
to
862665c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would trigger it for every Composite present in the C-cache.
It is now done when the Op is initialized.