Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in local_dimshuffle_subtensor rewrite #438

Merged

Conversation

ricardoV94
Copy link
Member

This showed up now that we improved the static type of subtensors and there are more cases where we can "squeeze" degenerate dims coming out of subtensor operations.

Showed up in pymc-devs/pymc#6897

@ricardoV94 ricardoV94 added bug Something isn't working graph rewriting labels Sep 12, 2023
@ricardoV94 ricardoV94 marked this pull request as ready for review September 12, 2023 13:17
@ricardoV94 ricardoV94 changed the title Fix bug in local_dimshuffle_subtensor rewrite Fix bug in local_dimshuffle_subtensor rewrite Sep 12, 2023
Copy link
Member

@twiecki twiecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't read through the logic.

@ricardoV94 ricardoV94 merged commit 8dc67ea into pymc-devs:main Sep 12, 2023
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working graph rewriting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants