Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly prevent Python 3.12 #470

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Explicitly prevent Python 3.12 #470

merged 1 commit into from
Oct 9, 2023

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Oct 9, 2023

To discuss: If we don't support 3.12, maybe we should enforce this here in pyproject.toml?

I'm not convinced that this is the right move since it might slightly hinder testing. But if we are explicit, then this seems to me like the correct place for it.

Motivation for these changes

Source: #441 (comment)

Checklist

Major / Breaking Changes

  • ...

New features

  • ...

Bugfixes

  • ...

Documentation

  • ...

Maintenance

  • Put explicit Python version upper-bound

To discuss: If we don't support 3.12, maybe we should enforce this here in `pyproject.toml`?

Source: <#441 (comment)>

I'm not convinced that this is the right move since it might slightly hinder testing. But if we are explicit, then this seems to me like the correct place for it.
@ricardoV94
Copy link
Member

Should be enough to do it in PyTensor, since there's where the restriction comes from?

@maresb
Copy link
Contributor Author

maresb commented Oct 9, 2023

What do you mean by "do it in PyTensor"? This is the pyproject.toml for PyTensor, right?

@ricardoV94
Copy link
Member

I don't know why I thought this was the PyMC repo. Sorry :)

@maresb maresb merged commit 081a0b4 into main Oct 9, 2023
13 checks passed
@maresb maresb deleted the maresb-patch-1 branch October 9, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants