Fix numpy integer check in TensorType #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
changed the title
Bug introduced in 6834740
ricardoV94
force-pushed
the
fix_int_check
branch
from
1965344
to
c5b8325
Compare
twiecki
approved these changes
Oct 17, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #478 +/- ##
=======================================
Coverage 80.66% 80.66%
=======================================
Files 160 160
Lines 46025 46029 +4
Branches 11266 11268 +2
=======================================
+ Hits 37124 37128 +4
Misses 6668 6668
Partials 2233 2233
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug introduced in 6834740
This caused PyMC Windows tests to fail, because integers default to int32 there instead of int64. Anyway, any integer type should be fine.