Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ChiSquare via Gamma #490

Merged
merged 4 commits into from Nov 15, 2023
Merged

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Nov 12, 2023

Motivation for these changes

Simplify by using the gamma distribution directly based on PyMC PR

Implementation details

Remove any ChiSquare reference including the rewrites and documentation

Checklist

Major / Breaking Changes

  • ChiSquareRV doesn't exist

New features

  • ...

Bugfixes

  • ...

Documentation

  • Removal of ChiSquareRV

Maintenance

  • ...

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2023

Codecov Report

Merging #490 (b720605) into main (0f802ab) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #490   +/-   ##
=======================================
  Coverage   80.76%   80.76%           
=======================================
  Files         161      161           
  Lines       46080    46070   -10     
  Branches    11258    11256    -2     
=======================================
- Hits        37218    37210    -8     
+ Misses       6635     6634    -1     
+ Partials     2227     2226    -1     
Files Coverage 螖
pytensor/link/numba/dispatch/random.py 98.83% <酶> (-0.01%) 猬囷笍
pytensor/tensor/random/basic.py 99.04% <100.00%> (-0.02%) 猬囷笍
pytensor/tensor/random/rewriting/jax.py 100.00% <酶> (酶)

... and 2 files with indirect coverage changes

Copy link
Member

@ricardoV94 ricardoV94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wd60622
Copy link
Contributor Author

wd60622 commented Nov 13, 2023

Thanks!

Thanks for the feedback!

@ricardoV94 ricardoV94 merged commit 902eeb6 into pymc-devs:main Nov 15, 2023
53 checks passed
@wd60622 wd60622 deleted the chisquare_helper branch November 15, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants