Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not merge while scans with different until condition #510

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

ricardoV94
Copy link
Member

Closes #509

@ricardoV94 ricardoV94 added bug Something isn't working graph rewriting scan labels Nov 22, 2023
The rewrite did not check if nominal variables in the graph of the until condition corresponded to the equivalent outer variables
@ricardoV94 ricardoV94 merged commit 91d3b7c into pymc-devs:main Nov 23, 2023
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working graph rewriting scan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite wrongly merges two distinct while scans
2 participants