Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make params exclusive to COps #513

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Make params exclusive to COps #513

merged 2 commits into from
Nov 24, 2023

Conversation

ricardoV94
Copy link
Member

Closes #511

@ricardoV94 ricardoV94 force-pushed the remove_params_signature branch 2 times, most recently from 539124e to 5fce452 Compare November 22, 2023 15:08
ricardoV94
ricardoV94 commented Nov 22, 2023
View reviewed changes
pytensor/link/c/basic.py
@@ -803,7 +809,10 @@ def code_gen(self):

sub = dict(failure_var=failure_var)

params = node.run_params()
try:
Copy link
Member Author

@ricardoV94 ricardoV94 Nov 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We raise 4 lines above if it's not a ClinkerOp

@codecov-commenter
Copy link

Codecov Report

Merging #513 (1b242b9) into main (eb552ee) will decrease coverage by 0.01%.
The diff coverage is 86.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #513      +/-   ##
==========================================
- Coverage   80.78%   80.78%   -0.01%     
==========================================
  Files         162      162              
  Lines       46172    46161      -11     
  Branches    11283    11279       -4     
==========================================
- Hits        37302    37293       -9     
+ Misses       6640     6637       -3     
- Partials     2230     2231       +1
Files Coverage Δ
pytensor/graph/basic.py 89.32% <ø> (-0.08%) ⬇️
pytensor/graph/op.py 87.50% <100.00%> (+0.24%) ⬆️
pytensor/link/c/op.py 61.00% <100.00%> (ø)
pytensor/link/numba/dispatch/basic.py 86.18% <100.00%> (+1.02%) ⬆️
pytensor/raise_op.py 98.76% <100.00%> (ø)
pytensor/scan/op.py 84.71% <100.00%> (ø)
pytensor/tensor/blas.py 65.27% <100.00%> (ø)
pytensor/tensor/elemwise.py 88.57% <100.00%> (ø)
pytensor/tensor/extra_ops.py 88.53% <100.00%> (ø)
pytensor/tensor/math.py 90.18% <100.00%> (ø)
... and 6 more

@ricardoV94
Copy link
Member Author

Would like to get this merged before the next release

twiecki
twiecki approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@twiecki twiecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification. I guess the COps still need params?

@twiecki twiecki merged commit 861f95c into pymc-devs:main Nov 24, 2023
53 checks passed
@ricardoV94
Copy link
Member Author

Yup

@michaelosthege michaelosthege mentioned this pull request Nov 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twiecki twiecki twiecki approved these changes

@jessegrabowski jessegrabowski Awaiting requested review from jessegrabowski

Assignees
No one assigned
Labels
C-backend maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove params in python perform method
3 participants
@ricardoV94 @codecov-commenter @twiecki