Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aliases to reflect package name #547

Merged
merged 4 commits into from
Dec 11, 2023

Conversation

jessegrabowski
Copy link
Member

@jessegrabowski jessegrabowski commented Dec 11, 2023

Description

This PR changes all the aliases in all the code from at, aes, aer, etc., to pt, ps, ptr, etc. This includes in tests, docs, and the main codebase.

Also I directly changed the .rst files in the docs, I'm not sure if I was supposed to do that, or if those are auto-generated?

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ricardoV94
Copy link
Member

ricardoV94 commented Dec 11, 2023

There's many more import pytensor.tensor as at in the codebase. Do you want to fix it or remove the one test file you changed? Otherwise it's a bit odd (but not a big deal). That touches on #380

@jessegrabowski
Copy link
Member Author

jessegrabowski commented Dec 11, 2023

I'll just do it all what the heck.

Unless you want it in a different PR. If so I'll revert the one test file I got and open another one later to handle the codebase itself.

Change `import pytensor.scalar as aes` to `as ps` everywhere

Change `import pytensor.tensor.random as aer` to `as ptr` everywhere

Change test variables with `_at` suffix or `at_` prefix to `_pt` and `pt_`, respectively
@jessegrabowski jessegrabowski changed the title Change import pytensor.tensor as at to as pt everywhere in the docs Update aliases to reflect package name Dec 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2023

Codecov Report

Merging #547 (105e954) into main (2cef9c0) will not change coverage.
The diff coverage is 94.33%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #547   +/-   ##
=======================================
  Coverage   80.90%   80.90%           
=======================================
  Files         162      162           
  Lines       46415    46415           
  Branches    11353    11353           
=======================================
  Hits        37553    37553           
  Misses       6639     6639           
  Partials     2223     2223           
Files Coverage Δ
pytensor/breakpoint.py 55.00% <ø> (ø)
pytensor/compile/builders.py 77.17% <100.00%> (ø)
pytensor/graph/basic.py 89.08% <ø> (ø)
pytensor/graph/rewriting/kanren.py 100.00% <ø> (ø)
pytensor/ifelse.py 51.70% <100.00%> (ø)
pytensor/link/jax/dispatch/random.py 96.05% <100.00%> (ø)
pytensor/link/jax/dispatch/shape.py 87.09% <ø> (ø)
pytensor/link/jax/dispatch/subtensor.py 88.13% <ø> (ø)
pytensor/link/jax/dispatch/tensor_basic.py 91.96% <ø> (ø)
pytensor/link/numba/dispatch/random.py 98.83% <100.00%> (ø)
... and 36 more

@jessegrabowski
Copy link
Member Author

@ricardoV94 I think I got everything

@ricardoV94
Copy link
Member

@ricardoV94 I think I got everything

I'll take your word for it. If this was your long con to mine bitcoin from pymc users hats-off to you in advance

@ricardoV94 ricardoV94 merged commit 9df55cc into pymc-devs:main Dec 11, 2023
53 checks passed
@jessegrabowski jessegrabowski deleted the pytensor-docs branch December 11, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants