Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug where ShapeFeature would create circular shape graph #566

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Fix bug where ShapeFeature would create circular shape graph #566

merged 1 commit into from
Jan 2, 2024

Conversation

ricardoV94
Copy link
Member

Description

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

@ricardoV94 ricardoV94 mentioned this pull request Dec 28, 2023
Closed
@ricardoV94 ricardoV94 merged commit e180927 into pymc-devs:main Jan 2, 2024
51 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twiecki twiecki twiecki approved these changes

Assignees
No one assigned
Labels
bug Something isn't working graph rewriting shape problem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

local_shape_to_shape_i can make graphs circular
2 participants
@ricardoV94 @twiecki