Fix vectorize_graph bug when replacements were provided for only some outputs of a node
#570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
fix_vectorize_bug
branch
from
5d8ea26
to
370c90e
Compare
ricardoV94
changed the title
vectorize_graph issue when replacements were provided only some outputs of a multi-output node
ricardoV94
changed the title
vectorize_graph issue when replacements were provided only some outputs of a multi-output nodevectorize_graph issue when replacements were provided only some outputs of a node
ricardoV94
changed the title
vectorize_graph issue when replacements were provided only some outputs of a nodevectorize_graph bug when replacements were provided only some outputs of a node
ricardoV94
force-pushed
the
fix_vectorize_bug
branch
from
370c90e
to
e2132f6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #570 +/- ##
=======================================
Coverage 80.92% 80.92%
=======================================
Files 162 162
Lines 46524 46526 +2
Branches 11375 11376 +1
=======================================
+ Hits 37648 37650 +2
Misses 6653 6653
Partials 2223 2223
|
ricardoV94
changed the title
vectorize_graph bug when replacements were provided only some outputs of a nodevectorize_graph bug when replacements were provided for only some outputs of a node
ricardoV94
commented
Jan 5, 2024
ricardoV94
commented
Jan 5, 2024
…utputs of a node The provided output could be silently ignored and replaced by the new output of the vectorized node. The changes also avoid vectorizing multiple-output nodes when none of the unreplaced outputs are needed.
ricardoV94
force-pushed
the
fix_vectorize_bug
branch
from
e2132f6
to
77b8389
Compare
twiecki
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The provided output could be silently ignored and replaced by the new output of the vectorized node.
Also avoids vectorizing multiple-output nodes when none of the unreplaced outputs are needed.
Related Issue
vectorize_graphwith multi-output nodes #569Checklist
Type of change