Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement numba overload for POTRF, LAPACK cholesky routine #578

Merged
merged 9 commits into from Jan 15, 2024

Conversation

jessegrabowski
Copy link
Member

Description

Tests are failing on #577 for the numba overloaded cholesky routine and I realized we didn't have a real one, so here it is. Now fully compatible with all the scipy keyword arguments. In addition, it will no longer drop numba into object mode.

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2024

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (c5b96d9) 80.92% compared to head (614fb1a) 80.88%.
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #578      +/-   ##
==========================================
- Coverage   80.92%   80.88%   -0.05%     
==========================================
  Files         162      162              
  Lines       46641    46690      +49     
  Branches    11399    11412      +13     
==========================================
+ Hits        37746    37766      +20     
- Misses       6667     6695      +28     
- Partials     2228     2229       +1     
Files Coverage Δ
pytensor/link/numba/dispatch/basic.py 85.68% <100.00%> (-0.51%) ⬇️
pytensor/tensor/slinalg.py 93.71% <100.00%> (+0.01%) ⬆️
pytensor/link/numba/dispatch/slinalg.py 47.54% <41.42%> (+1.93%) ⬆️

... and 1 file with indirect coverage changes

@ricardoV94
Copy link
Member

Shall I squash or do you want to tidy up the git history?

@jessegrabowski
Copy link
Member Author

I think it can squash? I was trying to keep thing tidy as I went. Well actually I tried to rearrange things to be ever better but it made a huge mess and I had to nuke and restart my local branch. So let me know if you want more done, and I'll do it. I'm happy on my end.

@ricardoV94 ricardoV94 merged commit 197069d into pymc-devs:main Jan 15, 2024
53 checks passed
@jessegrabowski jessegrabowski deleted the numba-cholesky branch January 15, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants