Deprecate ScalarSharedVariable #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
deprecate_scalar_shared_variable
branch
from
91bfe7a
to
ae4fe70
Compare
michaelosthege
approved these changes
Feb 5, 2024
pytensor/tensor/sharedvar.py
Outdated
Comment on lines
12
to
23
| def __getattr__(name): | ||
| if name == "ScalarSharedVariable": | ||
| warnings.warn( | ||
| "The class `ScalarSharedVariable` has been deprecated. " | ||
| "Use `TensorSharedVariable` instead and check for `ndim==0`.", | ||
| FutureWarning, | ||
| ) | ||
| return TensorSharedVariable | ||
|
|
||
|
|
There was a problem hiding this comment.
Oops not clever enough, have to fallback to AttributeError
ricardoV94
force-pushed
the
deprecate_scalar_shared_variable
branch
from
ae4fe70
to
e82d86c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #629 +/- ##
=======================================
Coverage 80.82% 80.83%
=======================================
Files 162 162
Lines 46744 46743 -1
Branches 11418 11417 -1
=======================================
+ Hits 37783 37786 +3
+ Misses 6716 6714 -2
+ Partials 2245 2243 -2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As explained in the related issue this class is messy because it internally upcasts the values to 0d arrays, so that
shared(shared(5).get_value())belongs to a different class thanshared(5)but are exactly the same objects otherwise!This was a source of bugs in PyMC. The way you create an object shouldn't matter for type checks, only what you actually ended up creating!
There is a proper ScalarSharedVariable if someone really wants to work with scalar types
Related Issue
tensor.ScalarSharedVariable#396Checklist
Type of change