-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent local_sum_make_vector
from introducing forbidden float64
#659
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #659 +/- ##
=======================================
Coverage 80.82% 80.82%
=======================================
Files 162 162
Lines 46820 46822 +2
Branches 11438 11439 +1
=======================================
+ Hits 37844 37846 +2
Misses 6725 6725
Partials 2251 2251
|
@ricardoV94 I implemented your less-restrictive approach and updated the tests. This PR is ready to review/merge |
@ricardoV94 new tests implemented and ready for review/merge |
@ricardoV94 Just a reminder that this PR is ready for review! Thanks for your help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for not only fixing the issue but sticking around to also improve the tests!
Description
This PR changes the behavior of
local_sum_make_vector
to skip rewriting whenever the internal accumulator is more precise than both the input/output data andconfig.floatX
. Otherwise, the internal accumulator is added to the graph, which can introduce forbiddenfloat64
to the graph when the user requestsconfig.floatX="float32"
.Replaces PR #655 and #656
Related Issue
local_sum_make_vector
rewrite can introduce forbidden float64 operations at the graph level #653Checklist
Type of change