-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dimshuffle does not need input broadcastable info #979
Merged
ricardoV94
merged 3 commits into
pymc-devs:main
from
ricardoV94:dimshuffle_does_not_need_input_broadcastable_info
Oct 8, 2024
Merged
Dimshuffle does not need input broadcastable info #979
ricardoV94
merged 3 commits into
pymc-devs:main
from
ricardoV94:dimshuffle_does_not_need_input_broadcastable_info
Oct 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
added
bug
Something isn't working
maintenance
Op implementation
shape inference
labels
Aug 22, 2024
ricardoV94
force-pushed
the
dimshuffle_does_not_need_input_broadcastable_info
branch
from
August 22, 2024 12:44
0a667f6
to
278faf6
Compare
ricardoV94
force-pushed
the
dimshuffle_does_not_need_input_broadcastable_info
branch
5 times, most recently
from
August 24, 2024 10:07
0556779
to
57ff2b7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #979 +/- ##
=======================================
Coverage 81.73% 81.73%
=======================================
Files 183 183
Lines 47734 47721 -13
Branches 11611 11601 -10
=======================================
- Hits 39016 39007 -9
+ Misses 6523 6521 -2
+ Partials 2195 2193 -2
|
ricardoV94
force-pushed
the
dimshuffle_does_not_need_input_broadcastable_info
branch
from
August 24, 2024 18:48
d573dd3
to
bf9f33b
Compare
ricardoV94
force-pushed
the
dimshuffle_does_not_need_input_broadcastable_info
branch
from
October 7, 2024 07:27
bf9f33b
to
47f2dc9
Compare
twiecki
reviewed
Oct 7, 2024
ricardoV94
force-pushed
the
dimshuffle_does_not_need_input_broadcastable_info
branch
from
October 7, 2024 13:11
47f2dc9
to
4b834aa
Compare
ricardoV94
force-pushed
the
dimshuffle_does_not_need_input_broadcastable_info
branch
from
October 7, 2024 13:18
4b834aa
to
2425c9a
Compare
twiecki
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make DimShuffle less concerned about it's input static broadcastable type when dropping dims, since no behavior depends on it being specified at runtime.
But there is no reason the input broadcastable type had to be known in advance, since no behavior of the Op changes with that information. It's true that dropping it only works when the runtime shape is of length 1, but that will naturally fail when we try to do it for different shape lengths.
Alternatively / in addition we could plaster
specify_broadcastable
during make_node. Beyond this potential extension, I see no reason why DimShuffle should be so strict.This fixes the bug reported in #969
Related Issue