Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deepcopy of posterior to allow second fit call #790

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Jun 28, 2024

Description

After #741 , there are issues with a second call to fit method. They are:

  • fit_data already existing from first call and causing error from add_groups
  • stored off idata having issue with not being copied

Related Issue

  • Closes #
  • Related to #

Checklist

Modules affected

  • MMM
  • CLV

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--790.org.readthedocs.build/en/790/

@wd60622 wd60622 added bug Something isn't working MMM model builder labels Jun 28, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@wd60622 wd60622 requested a review from juanitorduz June 28, 2024 05:42
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.90%. Comparing base (cec2cc2) to head (e0ed734).
Report is 183 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #790   +/-   ##
=======================================
  Coverage   93.89%   93.90%           
=======================================
  Files          28       28           
  Lines        2948     2951    +3     
=======================================
+ Hits         2768     2771    +3     
  Misses        180      180           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juanitorduz
Copy link
Collaborator

Thank you @wd60622 !

@juanitorduz juanitorduz merged commit f6a1a37 into main Jun 28, 2024
12 checks passed
@juanitorduz juanitorduz added this to the 0.7.0 milestone Jun 28, 2024
@wd60622 wd60622 deleted the lift-test-notebook-fixes branch July 1, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working MMM model builder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants