Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linear trend #991

Merged
merged 15 commits into from
Sep 2, 2024
Merged

Linear trend #991

merged 15 commits into from
Sep 2, 2024

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Aug 29, 2024

Description

Linear trend using change points

CC: @cetagostini

Related Issue

  • Closes #
  • Related to #

Checklist

Modules affected

  • MMM
  • CLV

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

@wd60622 wd60622 added enhancement New feature or request MMM labels Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 98.98990% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.58%. Comparing base (2e2907a) to head (e59d777).

Files with missing lines Patch % Lines
pymc_marketing/mmm/linear_trend.py 98.97% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #991      +/-   ##
==========================================
+ Coverage   95.48%   95.58%   +0.09%     
==========================================
  Files          37       38       +1     
  Lines        3592     3691      +99     
==========================================
+ Hits         3430     3528      +98     
- Misses        162      163       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wd60622 wd60622 marked this pull request as ready for review August 30, 2024 04:43
Copy link
Collaborator

@juanitorduz juanitorduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I left some suggestions, let me know what you think.

pymc_marketing/mmm/linear_trend.py Show resolved Hide resolved
pymc_marketing/mmm/linear_trend.py Outdated Show resolved Hide resolved
pymc_marketing/mmm/linear_trend.py Outdated Show resolved Hide resolved
pymc_marketing/mmm/linear_trend.py Show resolved Hide resolved
pymc_marketing/mmm/linear_trend.py Outdated Show resolved Hide resolved
@juanitorduz
Copy link
Collaborator

Also, latex need some work

image

Copy link
Contributor Author

@wd60622 wd60622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback, will work through implementation when I get the chance

pymc_marketing/mmm/linear_trend.py Show resolved Hide resolved
pymc_marketing/mmm/linear_trend.py Outdated Show resolved Hide resolved
pymc_marketing/mmm/linear_trend.py Show resolved Hide resolved
pymc_marketing/mmm/linear_trend.py Outdated Show resolved Hide resolved
pymc_marketing/mmm/linear_trend.py Outdated Show resolved Hide resolved
@wd60622
Copy link
Contributor Author

wd60622 commented Sep 1, 2024

Addressed all of the feedback @juanitorduz
Waiting on the docs to build in order to check the new latex 🚀

Copy link
Collaborator

@juanitorduz juanitorduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@juanitorduz juanitorduz merged commit f1e86c9 into main Sep 2, 2024
11 of 12 checks passed
@juanitorduz juanitorduz deleted the linear-trend branch September 2, 2024 08:05
twiecki pushed a commit that referenced this pull request Sep 10, 2024
* push up some linear-trend work I had

* image for the documentation

* start the slopes at t=0

* additional checks at init

* import at mmm module

* update the image

* Move to reference section

* Move coords to single line

* Add hierarchical trend example

* add image for the example

* migrate to pydantic

* update images after seed

* Correct the latex

* fix check from tests
twiecki pushed a commit that referenced this pull request Sep 10, 2024
* push up some linear-trend work I had

* image for the documentation

* start the slopes at t=0

* additional checks at init

* import at mmm module

* update the image

* Move to reference section

* Move coords to single line

* Add hierarchical trend example

* add image for the example

* migrate to pydantic

* update images after seed

* Correct the latex

* fix check from tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request MMM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants