-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linear trend #991
Linear trend #991
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #991 +/- ##
==========================================
+ Coverage 95.48% 95.58% +0.09%
==========================================
Files 37 38 +1
Lines 3592 3691 +99
==========================================
+ Hits 3430 3528 +98
- Misses 162 163 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I left some suggestions, let me know what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback, will work through implementation when I get the chance
Addressed all of the feedback @juanitorduz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
* push up some linear-trend work I had * image for the documentation * start the slopes at t=0 * additional checks at init * import at mmm module * update the image * Move to reference section * Move coords to single line * Add hierarchical trend example * add image for the example * migrate to pydantic * update images after seed * Correct the latex * fix check from tests
* push up some linear-trend work I had * image for the documentation * start the slopes at t=0 * additional checks at init * import at mmm module * update the image * Move to reference section * Move coords to single line * Add hierarchical trend example * add image for the example * migrate to pydantic * update images after seed * Correct the latex * fix check from tests
Description
Linear trend using change points
CC: @cetagostini
Related Issue
Checklist
Modules affected
Type of change