Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand test coverage #81

Merged
merged 5 commits into from
May 16, 2024
Merged

Expand test coverage #81

merged 5 commits into from
May 16, 2024

Conversation

BenediktBurger
Copy link
Member

No description provided.

@BenediktBurger BenediktBurger force-pushed the expand-test-coverage branch 3 times, most recently from 286bb5c to 31460d2 Compare May 15, 2024 15:09
@BenediktBurger
Copy link
Member Author

Somehow the proxy_server test does hang

@BenediktBurger BenediktBurger marked this pull request as ready for review May 16, 2024 12:04
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 89.04%. Comparing base (5235b4d) to head (a09506c).
Report is 4 commits behind head on main.

Files Patch % Lines
pyleco/management/starter.py 50.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   87.59%   89.04%   +1.44%     
==========================================
  Files          36       36              
  Lines        2903     2902       -1     
  Branches      355      355              
==========================================
+ Hits         2543     2584      +41     
+ Misses        300      267      -33     
+ Partials       60       51       -9     
Flag Coverage Δ
unittests 89.04% <50.00%> (+1.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BenediktBurger
Copy link
Member Author

The tests fail due to some obscure bug in setuptools_scm version recovery, see pypa/setuptools-scm#1038

Bump therefore setuptools requirement.

@BenediktBurger
Copy link
Member Author

The tests fail due to some obscure bug in setuptools_scm version recovery, see pypa/setuptools_scm#1038

Bump therefore setuptools requirement.

Does not work as expected, now even more runners fail 🤦

@BenediktBurger BenediktBurger merged commit 4b3d071 into main May 16, 2024
24 of 38 checks passed
@BenediktBurger BenediktBurger deleted the expand-test-coverage branch May 16, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant