Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add try/catch block around localStorage.setItem call #11546

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

dotsam
Copy link
Contributor

@dotsam dotsam commented Nov 1, 2023

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

Safari in particular isn't happy with the size of the shows localStorage item and will often throw a quota error. Catch the error to allow the show delete to continue

@medariox
Copy link
Contributor

Thank you for the PR! 👍

@medariox medariox merged commit e3a5916 into pymedusa:develop Nov 19, 2023
8 of 11 checks passed
@medariox medariox added this to the 1.0.19 milestone Nov 19, 2023
@medariox medariox added the Bug label Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants