Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing release group in Animebytes results (#11648) #11649

Merged
merged 6 commits into from
Mar 17, 2024

Conversation

k0mmsussert0d
Copy link
Contributor

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

Animebytes has changed their torrent Property string format. For ongoing series it contains an episode number as second to last segment, e.g. 'Web|MKV|h264|720p|AAC2.0|Softsubs(SubsPlease)|Episode26|Freeleech'.

For finished series, the format is unchanged.

Provider's parse() removes Freeleech segment from the split string, then expects to find the release group name in the last string of an array. This is not the case for ongoing series, where the last string represent an episode number. To find the actual release group name, last two strings should be checked.

I intended to provide a test case to facilitate adapting this provider to any future changes of Animebytes data schema. Unfortunately, being unable to configure the authorized provider in the test suite I couldn't record a VCR cassette for the request. I asked more specific questions about providers initialization process in the project's Discord. If you could find some time to explain this mechanism to me, I can provide test coverage for this and other similar providers.

@medariox medariox merged commit 70f9e90 into pymedusa:develop Mar 17, 2024
9 of 11 checks passed
@k0mmsussert0d k0mmsussert0d deleted the bugfix/11648 branch March 17, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants