Choose show's root at /home #2231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
fernandog
force-pushed
the
feature/root_dir_home
branch
4 times, most recently
from
a0bcd52
to
c0f8e66
Compare
(cherry picked from commit 0d9e55fb82d327a2cfb8bde6adb0486801b61499)
fernandog
force-pushed
the
feature/root_dir_home
branch
from
c0f8e66
to
1bd3124
Compare
fernandog
added
Awaiting approval
Concluded
Needs review
and removed
In progress
labels
OmgImAlexis
reviewed
Feb 21, 2017
| @@ -1466,6 +1467,7 @@ def save_config(): | |||
| new_config['General']['display_all_seasons'] = int(app.DISPLAY_ALL_SEASONS) | |||
| new_config['General']['news_last_read'] = app.NEWS_LAST_READ | |||
| new_config['General']['broken_providers'] = helpers.get_broken_providers() or app.BROKEN_PROVIDERS | |||
| new_config['General']['shows_root'] = int(app.SHOWS_ROOT) | |||
There was a problem hiding this comment.
Is this meant to be an int?
There was a problem hiding this comment.
Yes. Its a index of which root folder was used
OmgImAlexis
reviewed
Feb 21, 2017
| } | ||
| }).then(function(response) { | ||
| log.info(response); | ||
| window.location.reload(); |
There was a problem hiding this comment.
You may not want this here as it'll reload the page on change.
There was a problem hiding this comment.
@fernandog this may have been what was causing the other page to reload, no?
There was a problem hiding this comment.
By design to only get shows with that root
OmgImAlexis
approved these changes
Feb 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choose show's root at /home
@wimpyrbx @Thraxis
need help to make the select more aligned with other objects