Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable PP wrapper, since it makes NzbToMedia to not function properly #290

Merged
merged 1 commit into from
Apr 8, 2016

Conversation

duramato
Copy link
Contributor

@duramato duramato commented Apr 7, 2016

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read contribution guide

@p0psicles
Copy link
Contributor

Let's hold off this PR for now. Things i want to look into are queuing of the PP jobs.
I think we should implement this. IMO we have the following solution alternatives:

  1. Implement queuing in Medusa. nzbToMedia will deliver a job with medusa, it's queued, and we need to create some sort of callback to nzbToMedia, to update it's db.
  2. Implement queing in nzbToMedia, and make it send jobs to medusa synchronous.
  3. Integrate nzbToMedia in medusa, and let download client communicate directly with medusa. This will be sort of a solution like number, with the difference that we won't need to make callbacks.

@pymedusa/developers what do you guys think?

Just had a chat with @duramato. But the only issue we're having is when you AutoPP and Manual PP the same file at the same time. Which IMO is pretty rare?!

@fernandog
Copy link
Contributor

@duramato @p0psicles
merge or not to merge?

@p0psicles
Copy link
Contributor

sure merge it. To much trouble to really properly test now anyway.

@p0psicles
Copy link
Contributor

Approved!

Approved with PullApprove

@fernandog fernandog merged commit b9fbf91 into develop Apr 8, 2016
@fernandog fernandog deleted the wrapper branch April 8, 2016 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants