Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement episode and season search templates #3732

Merged
merged 139 commits into from
Jan 25, 2022

Conversation

p0psicles
Copy link
Contributor

@p0psicles p0psicles commented Feb 8, 2018

Implemented basic parsing of the templates for searching providers.

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

This will allow users to create their own custom (templated) search string per show.
For example sport shows like ufc and formula 1 should become available.

For now a limitation is that you can only create 1 templated episode search string and 1 templated season search string.

Should implement #3708

Todo:

  • Move scene_exceptions table to main.db
  • Refactor scene_exceptions to return a named_tuple in stead of tuple. This will include all information for one exception row. Like series_id, indexer, season, episode_template, season_template.
  • Make generic_provider create episode_search_strings using the scene_exception episode_search_template.
  • Make generic_provider create season_search_strings using the scene_exception season_search_template.
  • Create UI component for editing season scene exceptions
  • Create UI component for creating the episode and season search templates. These will write to scene_exceptions table
  • Add template variable for episode year (%EY)
  • Add template variable for month as a full name (%b)

for vue, working on the dark template.

  • Don't forget to sync up

Examples:

Series Name Example Result Search template Search String Example provider
Buried: Knights Templar And The Holy Grail Buried.Knights.Templar.and.the.Holy.Grail.2018.Part1.720p.WEB.h264-CookieMonster %SN.%Y.Part%E Buried Knights Templar And The Holy Grail.2018.Part1 TD
Burning Bush Burning.Bush.E01.1080p.BluRay.x264-TAXES %SN.%0E Burning Bush E01
Formula 1 Formula1.2017.Abu.Dhabi.Grand.Prix.UNCUT.1080p.HDTV.x264-GRiP %SN.%EY.%E.N Formula1.2017.Abu.Dhabi.Grand.Prix
The Jeremy Kyle Show ? %SN (%d %b %Y) The Jeremy Kyle Show (8 February 2018)

Implemented basic parsing of the templates for searching providers.
themes-default/slim/views/config.mako Outdated Show resolved Hide resolved
themes-default/slim/views/editShow.mako Outdated Show resolved Hide resolved
* Added new vue.js component to editShow, for configuring lists of strings.
* Added pencil_add.png img.
* Disabled some css. Need to clean this up.
p0psicles and others added 7 commits March 2, 2018 12:04
* Added anidb exception handling.
* Added dogpile for anidb get release groups.
Merge remote-tracking branch 'remotes/origin/develop' into feature/templated-search-strings

# Conflicts:
#	medusa/name_cache.py
#	medusa/name_parser/parser.py
#	medusa/scene_exceptions.py
#	medusa/tv/series.py
Connected anidbReleaseGroupUi component properly to editShow.mako.
return this.transformToIndexedObject(this.series.config.release.ignoredWords);
},
requiredWords() {
return this.transformToIndexedObject(this.series.config.release.requiredWords);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@p0psicles Instead of mutating the value in the DOM you should be doing in a computed property.

@p0psicles
Copy link
Contributor Author

PR is becoming to big. I'm going to move the vue changes to editShow to a dedicated PR.

@p0psicles p0psicles merged commit 3b6bbbe into develop Jan 25, 2022
@p0psicles p0psicles deleted the feature/templated-search-strings branch January 25, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Concluded Enhancement Migration Database and/or Config migration performed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants