Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix norbits provider not returning results. Fixes #3846 #4007

Merged
merged 5 commits into from
Apr 20, 2018

Conversation

medariox
Copy link
Contributor

@medariox medariox commented Apr 13, 2018

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

Thanks to @massifman and @labrys for finding the issue and suggesting the fix.

duramato
duramato previously approved these changes Apr 13, 2018
@labrys
Copy link
Contributor

labrys commented Apr 13, 2018

@medariox You didn't change the post data to json, was that intended?

@medariox
Copy link
Contributor Author

@labrys Yeah, in the end it didn't make a difference at all.

@massifman
Copy link

massifman commented Apr 14, 2018

@labrys @medariox No, I implemented the change on line 80(?) from
response = self.session.post(self.urls['search'], data=post_data)
to
response = self.session.post(self.urls['search'], json=post_data)
aswell, sorry if that was unclear in the issue thread.
Otherwise, it seems correct.

@medariox
Copy link
Contributor Author

medariox commented Apr 14, 2018

@massifman @labrys
I've changed to json, just in case. All changes should be there now.

@codecov-io
Copy link

Codecov Report

Merging #4007 into develop will decrease coverage by <.01%.
The diff coverage is 11.11%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4007      +/-   ##
===========================================
- Coverage    29.39%   29.38%   -0.01%     
===========================================
  Files          277      277              
  Lines        35496    35496              
===========================================
- Hits         10433    10432       -1     
- Misses       25063    25064       +1
Impacted Files Coverage Δ
medusa/providers/torrent/json/norbits.py 33.76% <11.11%> (-1.3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff468f2...deec850. Read the comment docs.

@medariox medariox merged commit 47cfea0 into develop Apr 20, 2018
@OmgImAlexis OmgImAlexis deleted the feature/fix-norbits-res branch April 20, 2018 16:18
@p0psicles p0psicles added this to the 0.2.2 milestone Apr 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants