Fix season search in tvcuk #497
Conversation
| @@ -102,7 +100,7 @@ def search(self, search_strings, age=0, ep_obj=None): # pylint: disable=too-man | |||
| for search_string in search_strings[mode]: | |||
|
|
|||
| if mode == 'Season': | |||
| search_string = re.sub(ur'(.*)Season', ur'\1Series', search_string) | |||
| search_string = re.sub(ur'(.*)S0?', ur'\1Series', search_string) | |||
There was a problem hiding this comment.
@duramato can you add comments with examples of releases that matches it ? Also s10 wont match, right?
what about releases like Show1.Season.6...... ?
There was a problem hiding this comment.
There are no Season 6, just Series 6.
They are all like that or at least 90%, making the 10% despicable
It always replaced them but replaced wrong
There was a problem hiding this comment.
What about seasons > 9? And series with a year for a season?
How about ur'\bs\d{1,4}\b' instead? It will match any Sx through Sxxxx. Also since it doesn't have the .* it will match multi-season too.
There was a problem hiding this comment.
Would it bring any advantage? The search string has multiple seasons?
With the current one it will only replace S to Series and if its a season shorter than 9 S0 to Series becouse in the site all seasons less than 10 dont have a 0 and if its searched with it no results will be returned
Also there arent any seasons with year from my research in the site
fernandog
force-pushed
the
tvcuk
branch
3 times, most recently
from
6989734
to
be0d559
Compare
|
@duramato If this tested good i think its ready for rebase and merge. |
labrys
added
the
Needs testing
Remove useless code
fernandog
removed
the
Needs testing
|
Approved |
|
Approved |
|
Attempted to kickstart QC by closing and re-opening with no luck. Forcing merge since QC is failing to report status. |
No description provided.