Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI bugs #5127

Merged
merged 5 commits into from
Sep 7, 2018
Merged

Fix UI bugs #5127

merged 5 commits into from
Sep 7, 2018

Conversation

sharkykh
Copy link
Contributor

@sharkykh sharkykh commented Sep 6, 2018

  • Show list bug when using tabs (after adding show)
    jQuery UI tabs widget was fetching the whole page using AJAX.
  • Pre-emptive fix for recommended shows (for the same tabs bug)
  • Fix status page with 3 or more root dirs is malformed:
    chrome_2018-09-06_22-08-36

We should wait a little more to see if more bugs pop up, if they do we should probably cherry pick fixes into a hotfix release.

@sharkykh sharkykh added Bug In progress Changelog Requires a changelog entry Frontend labels Sep 6, 2018
@sharkykh sharkykh added this to the 0.2.10 milestone Sep 6, 2018
@sharkykh

This comment has been minimized.

@sharkykh sharkykh added Concluded and removed Changelog Requires a changelog entry In progress labels Sep 6, 2018
Copy link
Collaborator

@OmgImAlexis OmgImAlexis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@medariox medariox merged commit 0fb8173 into develop Sep 7, 2018
@medariox medariox deleted the bugfix/home-tabs-bug branch September 7, 2018 14:56
@sharkykh sharkykh modified the milestones: 0.2.10, 0.2.10 (Hotfix) Sep 8, 2018
sharkykh added a commit that referenced this pull request Sep 8, 2018
* Fix home tabs bug (tested)

* Fix recommended shows tabs bug (pre-emptive)

* Fix status page with 3 or more root dirs is malformed

* Update changelog
@sharkykh sharkykh mentioned this pull request Sep 8, 2018
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants