Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature: Allow use of Pushover priorities. #5567

Merged
merged 8 commits into from
Nov 4, 2018
Merged

New feature: Allow use of Pushover priorities. #5567

merged 8 commits into from
Nov 4, 2018

Conversation

CerebralXor
Copy link
Contributor

Also, set default Pushover alert sound to whatever is configured on the receiving device, and fixed bug where unsuccessful notification were not being detected.

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

Also, the current Develop branch has an issue on the notifications page, spitting out a bunch of JS errors which are preventing the Enable toggle switches from displaying the relevant fields (this has occurred after #4913 was merged):

[Vue warn]: Error in callback for watcher "localValue": "TypeError: undefined is not an object (evaluating 'vm._events')"

found in

---> <ConfigTextbox> at src/components/helpers/config-textbox.vue
       <Root>

Also, set default Pushover alert sound to whatever is configured on the receiving device, and fixed bug where unsuccessful notification were not being detected.
@ghost
Copy link

ghost commented Oct 31, 2018

DeepCode analyzed this pull request.
There are no new issues.

@p0psicles
Copy link
Contributor

p0psicles commented Oct 31, 2018

Sorry for the errors. Is fixed here.. Should be merged today
#5557

@ghost
Copy link

ghost commented Nov 1, 2018

DeepCode analyzed this pull request.
There are no new issues.

@CerebralXor
Copy link
Contributor Author

No problems. I'll test this out now that #5557 has been merged and confirm shortly that this PR is tested and ready.

@CerebralXor
Copy link
Contributor Author

Looks good. This is ready to go.

@p0psicles
Copy link
Contributor

You need to run yarn dev in the slim folder

@ghost
Copy link

ghost commented Nov 2, 2018

DeepCode analyzed this pull request.
There are no new issues.

@p0psicles p0psicles merged commit f3be47a into pymedusa:develop Nov 4, 2018
@CerebralXor CerebralXor deleted the feature/pushover-priorities branch November 4, 2018 09:43
@sharkykh sharkykh added this to the 0.2.12 milestone Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants