-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added DELETE method for deleting an episode to the apiv2. #5685
Conversation
DELETE: /series/slug/episodes/slug/
DeepCode analyzed this pull request. |
Updated changelog.md.
@p0psicles does this allow deleting the file associated? |
@OmgImAlexis No my change doesn't |
@ratoaq2 I could use some help here with the api-description and the dredd tests? |
dredd/api-description.yml
Outdated
@@ -2342,6 +2370,13 @@ parameters: | |||
description: The episode id to retrieve. E.g. s02e03, e34 or 2016-12-31 | |||
x-example: s01e01 | |||
type: string | |||
episode-id-delete: | |||
name: episode-id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this also need -delete
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was an attempt to get the dredd test working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I mean is the ones above all have it matching with their name where as this one is missing the -delete
. Might be related.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh like that, i dont think the name makes any difference.
…mber > 99. Changed to maximum of 9999. * Changed maximum of absolute ep numbers from 999 -> 9999.
Dredd is fixed. Just need to update some unit tests |
DeepCode analyzed this pull request. |
DELETE: /series/slug/episodes/slug/