Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DELETE method for deleting an episode to the apiv2. #5685

Merged
merged 9 commits into from
Nov 12, 2018

Conversation

p0psicles
Copy link
Contributor

@p0psicles p0psicles commented Nov 10, 2018

DELETE: /series/slug/episodes/slug/

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

@ghost
Copy link

ghost commented Nov 10, 2018

DeepCode analyzed this pull request.
There are no new issues.

Updated changelog.md.
@p0psicles p0psicles added this to the 0.2.12 milestone Nov 10, 2018
@OmgImAlexis
Copy link
Collaborator

@p0psicles does this allow deleting the file associated?

@p0psicles
Copy link
Contributor Author

@OmgImAlexis No my change doesn't

@p0psicles
Copy link
Contributor Author

@ratoaq2 I could use some help here with the api-description and the dredd tests?

@@ -2342,6 +2370,13 @@ parameters:
description: The episode id to retrieve. E.g. s02e03, e34 or 2016-12-31
x-example: s01e01
type: string
episode-id-delete:
name: episode-id
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also need -delete?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was an attempt to get the dredd test working.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I mean is the ones above all have it matching with their name where as this one is missing the -delete. Might be related.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh like that, i dont think the name makes any difference.

…mber > 99.

Changed to maximum of 9999.
* Changed maximum of absolute ep numbers from 999 -> 9999.
@p0psicles
Copy link
Contributor Author

Dredd is fixed. Just need to update some unit tests

@ghost
Copy link

ghost commented Nov 12, 2018

DeepCode analyzed this pull request.
There are no new issues.

@medariox medariox merged commit 6bc3d49 into develop Nov 12, 2018
@medariox medariox deleted the feature/add-apiv2-episode-DELETE branch November 12, 2018 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants