Feature/enable check runs in docker #5700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used for checking if medusa is running in a docker container.
This prevents us from checking each time. * Renamed method. * Removed double quotes * escaped backslash.
* Show the app.RUNS_IN_DOCKER variable in the Help & Info page. * Add app.RUNS_IN_DOCKER to apiv2 config.
…able-check-runs-in-docker # Conflicts: # medusa/version_checker.py
|
DeepCode analyzed this pull request. |
Update unit test.
OmgImAlexis
reviewed
Nov 13, 2018
medusa/version_checker.py
Outdated
| if self.runs_in_docker() and (not self._cur_commit_hash or self._num_commits_behind > 0): | ||
| log.debug(u'There is an update available, medusa is running in a docker container, so auto updating is disabled.') | ||
| app.NEWEST_VERSION_STRING = 'There is an update available: please pull the latest docker image, ' \ | ||
| 'and rebuild your container to update' |
There was a problem hiding this comment.
Maybe we should link to somewhere in the wiki for this?
There was a problem hiding this comment.
Step by step. First prio, is to not have installations break.
I'd rather have users come over here, to ask how to update in docker for now.
There was a problem hiding this comment.
We could link to wiki?
There was a problem hiding this comment.
Okay, this works:
|
@sharkykh thoughts? |
Fixed alignment of the icons.
medariox
reviewed
Nov 13, 2018
…dateManager. Remove it from CheckVersion. Call app.RUNS_IN_DOCKER to check.
p0psicles
commented
Nov 14, 2018
medariox
previously approved these changes
Nov 14, 2018
medariox
approved these changes
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 2.
Enable the check. And visualize the result in the Help & Info page.
Next step will be to utilize the check, to prevent the automatic updating and restarting in docker containers. Need to figure out how that works first.
Should address some of the issues in: #5198
What I noticed is that there are two docker images widely used.
pymedusa/medusa
Does not configure a git repository on the app source within the container.
Therefor it uses the SourceUpdater.
linuxserver/medusa
Uses git, and uses the GitUpdater.
For both these containers, users where getting notifications when an update was available.
They could click the
update nowlink, to start the update process.This will now not be available to them anymore. So allot of users will be confused.
For now i've added the following message. But that can be modified of course:
There is an update available: please pull the latest docker image, and rebuild your container to updateI understand if some users think this is a step back. But this is the only way for now, to perform a reliable upgrade.