Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional fix for guessit multiple formats #780

Merged
merged 1 commit into from
Jul 19, 2016

Conversation

ratoaq2
Copy link
Contributor

@ratoaq2 ratoaq2 commented Jul 17, 2016

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read contribution guide

This should fix #772

The problem happened again because the file path has 2 portions with the same information, but the first part has a release group with additional words between brackets; so the second part would have all info except the release_group, which was affecting the logic of our fix.

@ratoaq2 ratoaq2 added Bug awaiting approval Needs review Needs testing Requires testing to make sure it's working as intended labels Jul 17, 2016
@ratoaq2 ratoaq2 self-assigned this Jul 17, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 28.454% when pulling 3d023a66647a24713925ab8bf442e7ffe2e8d8e1 on additional-fix-multiple-formats into cda3f54 on develop.

@fernandog
Copy link
Contributor

fernandog commented Jul 18, 2016

Approved

Approved with PullApprove

@fernandog
Copy link
Contributor

2016-07-18 18:58:15 DEBUG    FINDSUBTITLES :: [42fd472] Setting permissions for /media/SAMSUNG/media/downloaded/series/Mr.Robot.S02E02.eps2.0.unm4sk-pt2.tc.1080p.WEB-DL.DD5.1.H264-NTb[rarbg]/Mr.Robot.S02E02.eps2.0_unm4sk-pt2.tc.1080p.WEB-DL.DD5.1.H.264-NTb.pt-BR.srt to 644 as parent directory has 755
2016-07-18 18:58:14 INFO     FINDSUBTITLES :: [42fd472] Found subtitle for Mr.Robot.S02E02.eps2.0_unm4sk-pt2.tc.1080p.WEB-DL.DD5.1.H.264-NTb.mkv in legendastv provider with language pob
2016-07-18 18:58:13 DEBUG    FINDSUBTITLES :: [42fd472] [   legendastv:pt-BR] score = 332/352 for mr.robot.s02e02.720p.hdtv.x264-avs.srt
2016-07-18 18:58:13 DEBUG    FINDSUBTITLES :: [42fd472] [   legendastv:pt-BR] score = 332/352 for mr.robot.s02e02.hdtv.xvid-fum.srt
2016-07-18 18:58:13 DEBUG    FINDSUBTITLES :: [42fd472] [   legendastv:pt-BR] score = 332/352 for mr.robot.s02e02.hdtv.x264-killers.srt
2016-07-18 18:58:13 DEBUG    FINDSUBTITLES :: [42fd472] [   legendastv:pt-BR] score = 357/352 for mr.robot.s02e02.eps2.0_unm4sk-pt2.tc.720p.web-dl.dd5.1.h.264-ntb.srt
2016-07-18 18:58:13 DEBUG    FINDSUBTITLES :: [42fd472] [   legendastv:pt-BR] score = 359/352 for mr.robot.s02e02.eps2.0_unm4sk-pt2.tc.1080p.web-dl.dd5.1.h.264-ntb.srt
2016-07-18 18:58:03 DEBUG    FINDSUBTITLES :: [42fd472] Video information cached under key sickbeard.subtitles:video|/media/SAMSUNG/media/downloaded/series/Mr.Robot.S02E02.eps2.0.unm4sk-pt2.tc.1080p.WEB-DL.DD5.1.H264-NTb[rarbg]/Mr.Robot.S02E02.eps2.0_unm4sk-pt2.tc.1080p.WEB-DL.DD5.1.H.264-NTb.mkv
2016-07-18 18:58:00 DEBUG    FINDSUBTITLES :: [42fd472] Attribute audio_codec changed from AC3 to DolbyDigital
2016-07-18 18:57:59 DEBUG    FINDSUBTITLES :: [42fd472] Guessing using /media/SAMSUNG/media/downloaded/series/Mr.Robot.S02E02.eps2.0.unm4sk-pt2.tc.1080p.WEB-DL.DD5.1.H264-NTb[rarbg]/Mr.Robot.S02E02.eps2.0_unm4sk-pt2.tc.1080p.WEB-DL.DD5.1.H.264-NTb.mkv
2016-07-18 18:57:59 DEBUG    FINDSUBTITLES :: [42fd472] Starting release refiner [extension=release, release_name=Mr.Robot.S02E02.eps2.0_unm4sk-pt2.tc.1080p.WEB-DL.DD5.1.H.264-NTb, release_file=None]
2016-07-18 18:57:55 DEBUG    FINDSUBTITLES :: [42fd472] Scanning video /media/SAMSUNG/media/downloaded/series/Mr.Robot.S02E02.eps2.0.unm4sk-pt2.tc.1080p.WEB-DL.DD5.1.H264-NTb[rarbg]/Mr.Robot.S02E02.eps2.0_unm4sk-pt2.tc.1080p.WEB-DL.DD5.1.H.264-NTb.mkv...
2016-07-18 18:57:55 DEBUG    FINDSUBTITLES :: [42fd472] Parsed /media/SAMSUNG/media/downloaded/series/Mr.Robot.S02E02.eps2.0.unm4sk-pt2.tc.1080p.WEB-DL.DD5.1.H264-NTb[rarbg]/Mr.Robot.S02E02.eps2.0_unm4sk-pt2.tc.1080p.WEB-DL.DD5.1.H.264-NTb.mkv into Mr Robot - S02E02 [GROUP: NTb] [ABD: False] [ANIME: False] [whichReg: ['standard', 'standard']]

@fernandog fernandog removed the Needs testing Requires testing to make sure it's working as intended label Jul 18, 2016
… releases_groups and one with some non-release words
@coveralls
Copy link

coveralls commented Jul 18, 2016

Coverage Status

Coverage remained the same at 28.466% when pulling d0b5098 on additional-fix-multiple-formats into 0d210fc on develop.

@ratoaq2 ratoaq2 merged commit dfb86af into develop Jul 19, 2016
@labrys labrys added this to the 0.1.3 milestone Jul 19, 2016
@ratoaq2 ratoaq2 deleted the additional-fix-multiple-formats branch July 19, 2016 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants