-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional fix for guessit multiple formats #780
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratoaq2
added
Bug
awaiting approval
Needs review
Needs testing
Requires testing to make sure it's working as intended
labels
Jul 17, 2016
Coverage remained the same at 28.454% when pulling 3d023a66647a24713925ab8bf442e7ffe2e8d8e1 on additional-fix-multiple-formats into cda3f54 on develop. |
|
fernandog
removed
the
Needs testing
Requires testing to make sure it's working as intended
label
Jul 18, 2016
… releases_groups and one with some non-release words
fernandog
force-pushed
the
additional-fix-multiple-formats
branch
from
July 18, 2016 22:00
3d023a6
to
d0b5098
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #772
The problem happened again because the file path has 2 portions with the same information, but the first part has a release group with additional words between brackets; so the second part would have all info except the release_group, which was affecting the logic of our fix.