Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Keep link as post processing method #7986

Merged
merged 3 commits into from
Apr 20, 2020
Merged

Add Keep link as post processing method #7986

merged 3 commits into from
Apr 20, 2020

Conversation

jee-r
Copy link
Contributor

@jee-r jee-r commented Apr 19, 2020

  • PR is based on the DEVELOP branch
  • Don't send big changes all at once. Split up big PRs into multiple smaller PRs that are easier to manage and review
  • Read the contribution guide

Hi,
I hope I didn't make too many mistakes, the python workflow is very new to me.
Please don't hesitate to tell me what I did wrong if I did, I'd like to learn how to do things right thank you.

Related to this issue #6654

Copy link
Contributor

@medariox medariox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, thank you!

Please update the test snapshots with yarn test -u.

package.json Outdated
@@ -14,5 +14,6 @@
},
"devDependencies": {
"dredd": "12.2.1"
}
},
"version": "0.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the version

@medariox medariox added this to the 0.3.16 milestone Apr 19, 2020
@medariox medariox linked an issue Apr 19, 2020 that may be closed by this pull request
@p0psicles
Copy link
Contributor

An entry in the changelog.md would be nice

@jee-r
Copy link
Contributor Author

jee-r commented Apr 20, 2020

You'r right @p0psicles as well as updating the wiki but i don't know how edit the wiki

Should i add an entry in changelog.md under the Unreleased section ? like this :

## Unreleased

#### New Features
-  Add Keep link as post processing method ([6654](https://github.com/pymedusa/Medusa/issues/6654))

#### Improvements

#### Fixes

-----

## 0.3.15 (2020-04-13)

... etc

Btw @medariox is my last commit good ?

edit:
I see some changes on the develop branch since my last commit. What am I supposed to do and how ?
Sorry if my question is stupid this is really new to me.
Thank's

@p0psicles
Copy link
Contributor

Changelog is good!
You can PR the wiki.
I think the PR looks good. But @medariox is more into that part of the code

@p0psicles
Copy link
Contributor

No need to merge develop.
Only required when there are conflicts

@p0psicles
Copy link
Contributor

We link the number of the pr in the change log. Not the issue

@medariox medariox changed the title keeplink Add Keep link as post processing method Apr 20, 2020
@medariox
Copy link
Contributor

Awesome work, thanks! A Wiki entry is highly appreciated.

@medariox medariox merged commit 942312b into pymedusa:develop Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add Keep link as post processing method
3 participants