Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate reprofiled in Spectrum.__add__ if not present. #304

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

JB-Wolf
Copy link
Contributor

@JB-Wolf JB-Wolf commented Aug 29, 2022

Fixes spectra addition when the spectrum that is being added to has no "reprofiled" key in self._peak_dict

I was trying to add spectra together and it did not work - so I introduced suggested changes

Fixes spectra addition when the spectrum that is being added to has no "reprofiled" key in self._peak_dict
@sonarcloud
Copy link

sonarcloud bot commented Aug 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@MKoesters
Copy link
Contributor

Hi,
Thanks for the contribution.
We currently have a problem with the CI not running, but I was able to verify it locally.
I'll merge this soon and issue a new release.

Best,
Manuel

@MKoesters MKoesters merged commit fb27b80 into pymzml:dev Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants