Query fails with more than 10 attributes in a query filter condition.

[ezmuller]

Observed with range_key_placeholder == #1 this substring check failed because the condition included more than 10 placeholders. Since '#1' is a substring of '#10' this expression evaluates to True: (range_key_placeholder and range_key_placeholder in filter_expression) in pynamodb.connection.base.Connection.query ->

if filter_condition is not None:
    filter_expression = filter_condition.serialize(name_placeholders, expression_attribute_values)
    # FilterExpression does not allow key attributes. Check for hash and range key name placeholders
    hash_key_placeholder = name_placeholders.get(hash_keyname)
    range_key_placeholder = range_keyname and name_placeholders.get(range_keyname)
    if (
        hash_key_placeholder in filter_expression or
        (range_key_placeholder and range_key_placeholder in filter_expression)
    ):
        raise ValueError("'filter_condition' cannot contain key attributes")

[jpinner-lyft]

"fixed" in #800 by removing condition demotion entirely