Fix bug with double zoom initialisation #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, when calculating zoom windows, it was assumed that wrapping was available. But when a second-level zoom is opened, it is embedded in a domain that cannot be wrapped. The code would calculate a window that was only valid if wrapping were available, then correctly complain that the window lay outside the grid above. Solution is to clamp the window so that it can't go outside the grid above unless that grid is in fact the base-level grid. Add test
Will need to update Travis environment to use py3 later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug could cause a cryptic error to be issued when the second-level-zoom was not close-to-centred within the first-level-zoom.