-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SigmoidGauss3p to Actuators #185
Conversation
ActuatorSigmoidGauss3p
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job so far!
Please add a test for reading a comparing one or two values against what you have in Matlab (the appropriate test file to use is withAllActuatorsTypes.bioMod
thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! :)
I pushed a new version of RBDL that should fix the RBDL issue! |
Codecov Report
@@ Coverage Diff @@
## master #185 +/- ##
==========================================
+ Coverage 77.06% 77.19% +0.13%
==========================================
Files 93 94 +1
Lines 9495 9548 +53
==========================================
+ Hits 7317 7371 +54
+ Misses 2178 2177 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
GG |
No description provided.