Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SigmoidGauss3p to Actuators #185

Merged
merged 26 commits into from
Nov 9, 2020
Merged

Add SigmoidGauss3p to Actuators #185

merged 26 commits into from
Nov 9, 2020

Conversation

Steakkk
Copy link
Contributor

@Steakkk Steakkk commented Nov 6, 2020

No description provided.

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job so far!
Please add a test for reading a comparing one or two values against what you have in Matlab (the appropriate test file to use is withAllActuatorsTypes.bioMod
thanks!

src/Actuators/ActuatorSigmoidGauss3p.cpp Outdated Show resolved Hide resolved
include/Actuators/ActuatorSigmoidGauss3p.h Outdated Show resolved Hide resolved
include/Actuators/ActuatorSigmoidGauss3p.h Outdated Show resolved Hide resolved
pariterre
pariterre previously approved these changes Nov 8, 2020
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! :)

@pariterre
Copy link
Member

I pushed a new version of RBDL that should fix the RBDL issue!

@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #185 (7a7fc84) into master (c0963d7) will increase coverage by 0.13%.
The diff coverage is 59.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
+ Coverage   77.06%   77.19%   +0.13%     
==========================================
  Files          93       94       +1     
  Lines        9495     9548      +53     
==========================================
+ Hits         7317     7371      +54     
+ Misses       2178     2177       -1     
Impacted Files Coverage Δ
include/Actuators/ActuatorEnums.h 0.00% <0.00%> (ø)
src/Muscles/Geometry.cpp 57.54% <ø> (ø)
src/Muscles/Muscle.cpp 80.00% <ø> (ø)
src/Muscles/WrappingCylinder.cpp 76.02% <ø> (ø)
src/RigidBody/Contacts.cpp 82.08% <0.00%> (+1.20%) ⬆️
src/RigidBody/RotoTransNodes.cpp 52.17% <0.00%> (+2.85%) ⬆️
src/RigidBody/Joints.cpp 55.48% <31.57%> (+0.45%) ⬆️
src/RigidBody/Markers.cpp 42.32% <36.36%> (+1.26%) ⬆️
src/Actuators/Actuators.cpp 51.12% <47.36%> (-0.45%) ⬇️
src/Actuators/ActuatorSigmoidGauss3p.cpp 53.48% <53.48%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0963d7...7a7fc84. Read the comment docs.

pariterre
pariterre previously approved these changes Nov 9, 2020
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pariterre
pariterre previously approved these changes Nov 9, 2020
@pariterre
Copy link
Member

GG

@pariterre pariterre changed the title [WIP] Add SigmoidGauss3p to Actuators Add SigmoidGauss3p to Actuators Nov 9, 2020
@pariterre pariterre merged commit 4149000 into pyomeca:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants