Make abi3audit python 3.8 compatible #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
LGTM overall! I just cut |
ret2libc
force-pushed
the
py3.8-compatible
branch
from
0b949ee
to
d0e459a
Compare
|
Used newer version of abi3info and also used future annotations instead of Dict/Set/etc. |
woodruffw
reviewed
Jan 30, 2023
abi3audit/_audit.py
Outdated
| class AuditResult: | ||
| so: SharedObject | ||
| baseline: PyVersion | ||
| computed: PyVersion | ||
| non_abi3_symbols: set[Symbol] | ||
| future_abi3_objects: set[Function | Data] | ||
| future_abi3_objects: set[Union[Function, Data]] |
There was a problem hiding this comment.
FWIW the | syntax for Union should also work in deferred annotations with __future__ (it just doesn't work work in type aliases because those aren't deferred).
woodruffw
reviewed
Jan 30, 2023
woodruffw
reviewed
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.